search

Alvin-LB / NameTagChanger

Library to be shaded into Bukkit Plugins to allow for modification of player name tags.
MIT License
31 stars 10 forks source link

Fixes to pom.xml #1

Closed rayzr522 closed 7 years ago

rayzr522 commented 7 years ago

Feel free to deny this PR if you want, but a friend needed to use your API and he couldn't due to the 4.2.1-SNAPSHOT version on ProtocolLib-API. I fixed that, but then it was requiring a local JAR file for building and I really prefer this much more.

I'm not sure if removing the system of using the local JAR will break anything else, but it shouldn't, although to be fair I didn't really read too much into how you were loading the JAR.

Alvin-LB commented 7 years ago

I'm fully aware that my building system is completely stupid, I just want to be able to see the source code for CraftBukkit and NMS in IntelliJ together with some extra sources (long story..). But having that system is unacceptable for a public project like this one, so your changes are more than welcome!

Alvin-LB commented 7 years ago

And apparently I'm a total github greenhorn :P

rayzr522 commented 7 years ago

Not a problem at all, I'm honestly surprised you accepted so quickly. At least GitHub notifications are working properly...