search

Alvin-LB / NameTagChanger

Library to be shaded into Bukkit Plugins to allow for modification of player name tags.
MIT License
31 stars 10 forks source link

Catch "No field with type net.minecraft.server.v1_15_R1.DataWatcher e… #14

Closed SimonIT closed 4 years ago

SimonIT commented 4 years ago

…xists in class PacketPlayOutSpawnEntityLiving", fixes #13

Alvin-LB commented 4 years ago

Hi. I don't believe this will fix anything since it just catches the exception. Have you verified that this solution works?

This project needs proper updates and verifications for a number of versions (which I haven't done). If you are willing to try and do that, then feel free to, but I don't feel a solution like this will achieve anything.

SimonIT commented 4 years ago

Yes this fixed it for me. The label above the player and the skin got changed

Alvin-LB commented 4 years ago

Yes, I understand that it probably did, and feel free to use this workaround by yourself. The DataWatcher used to handle a bunch of subtle properties (like the glowing effect if memory serves me), and I have to make sure that these things are taken care of (I seriously doubt that everything works if you just catch the exception silently).

SimonIT commented 4 years ago

That's possible. I thought it's a good idea to share this quick and dirty workaround. I think a half working lib is better than a not working one ;) I tried to fix it as you can see here with sending an extra packet with this data as advised, but failed with the same exception

Alvin-LB commented 4 years ago

Okay. How about this: I will have a look at this within the coming week. If I can solve it properly I will do so, otherwise, I will merge your PR.

SimonIT commented 4 years ago

Thank you, I appreciate your help

SimonIT commented 4 years ago

So what going to happen?

SimonIT commented 4 years ago

@Alvin-LB Hm?