search

Alvinlj00 / pe

0 stars 0 forks source link

Anything after the 'view' command and the index is disregarded #5

Open Alvinlj00 opened 2 years ago

Alvinlj00 commented 2 years ago

When viewing an instrument, anything after the index input will be disregarded, even if it is another number. However, the instrument cannot be viewed if the index is not followed by whitespace.

image.png

soc-pe-bot commented 2 years ago

Team's Response

ss1.PNG

UG states that extraneous parameters are ignored. There is even an example usage of how "view 2 5" is interpreted.

ss7.PNG UG provided instructions of how to use the view command. It states "view INDEX". "INDEX" in the ug is defined as a positive index which represents a number. The addition of comma violates the instruction. ss8.PNG

Downgrading to Low as it does not affect functionality when instructions in user guide is followed.

This is a duplicate of issue #2907 as the problem lies in not following the UG instructions carefully which explains how extraneous parameters are handled.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

In multiple commands, entering anything after the main command and/or index will not be an error.

For add, list, view, done, edit, delete, and bye, anything that is entered after the main command or the index (if required) will be ignored. An exception should be thrown in this case to ensure the user does not accidentally do something they do not intend to.

image.png

image.png

image.png

[original: nus-cs2113-AY2122S1/pe-interim#2867] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

ss1.PNG

The user guide clearly states that extraneous parameters for all commands are ignored. The behaviour shown is expected. If user does not want to accidentally do something they do not intend to the first instinct is to backspace and delete what he/she has written, not add additional parameters and press enter.

The bug is downgraded to Low since this is not even a bug but has been addressed in the UG which mentions that extraneous parameters for all commands are ignored and this is beneficial to the user as their accidental extraneous parameters are discarded, thus making it more convenient to users.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]