Alvinn8 / paper-nms-maven-plugin

A maven plugin for using NMS on paper with Mojang mappings.
MIT License
112 stars 9 forks source link

Remapping error in multimodule project #23

Open ghost opened 10 months ago

ghost commented 10 months ago

Hey, I ran into the following error:

[INFO] --- paper-nms-maven-plugin:1.4.2:remap (default) @ v1_17_r1 ---
[INFO] Remapping classes
Mapping target name conflicts detected:
  METHODs net/minecraft/world/entity/projectile/EntityFireballFireball/[net/minecraft/world/entity/projectile/ItemSupplier/getItem, getSuppliedItem  METHODs net/minecraft/world/entity/projectile/EntityProjectileThrowable/[net/minecraft/world/entity/projectile/ItemSupplier/getItem, getSuppliedItemThere were unfixable conflicts.

I have the following module layout in my project: nms -> nms/accessor, nms/v1_17_r1. plugins -> plugins/platform, [...].

In nms/v1_17_r1 I have included the following plugin configuration:

<build>
    <plugins>
        <!-- Paper NMS Maven Plugin -->
        <plugin>
            <groupId>ca.bkaw</groupId>
            <artifactId>paper-nms-maven-plugin</artifactId>
            <version>1.4.2</version>
            <executions>
                <execution>
                    <phase>process-classes</phase>
                    <goals>
                        <goal>remap</goal>
                    </goals>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>

The plugins/platform module shades nms/accessor and nms/v1_17_r1. In my other project I used the following module layout, and with the same configuration everything worked: nms -> nms/accessor, nms/v1_17_r1. plugin-rewrite (no more submodules).

ghost commented 10 months ago

Also I don't think that this is related to https://github.com/Alvinn8/paper-nms-maven-plugin/issues/16 at all

Alvinn8 commented 9 months ago

It's interesting that you're getting a mapping conflict only for specific module layouts. I will check this out in more detail at a later date when I have more time.

Ekpoa commented 3 months ago

hey, is there any update on this? I believe i have a similar issue too. It gives out the error "method not found". I believe this is only for 1.20.6 due to paper's mapping changes. Only happens on mutli module projects