search

Alvinn8 / paper-nms-maven-plugin

A maven plugin for using NMS on paper with Mojang mappings.
MIT License
112 stars 9 forks source link

Using the 1.17.1 bundle results in unfixable conflicts at compile time #30

Open DerEchtePilz opened 3 months ago

DerEchtePilz commented 3 months ago

Not submitting the pom here for now, if you need it, please let me know

[INFO] --- paper-nms:1.4.4:remap (default) @ commandapi-paper-1.17-common ---
[INFO] Remapping classes
Mapping target name conflicts detected:
  METHODs net/minecraft/world/level/material/Material/[isBuildable, isSolidThere were unfixable conflicts.
[ERROR] Failed to execute goal ca.bkaw:paper-nms-maven-plugin:1.4.4:remap (default) on project commandapi-paper-1.17-common: Execution default of goal ca.bkaw:paper-nms-maven-plugin:1.4.4:remap failed: Unfixable conflicts -> [Help 1]
Alvinn8 commented 3 months ago

Do you mean 1.17? Your logs suggest it, but the title says 1.17.1. For 1.17.1 the paper dev bundle should be used, in which case mappings come from paper and don't need to be manually produced by this plugin.

Either way, I'm not able to reproduce this on 1.17. Looking at the mappings for 1.17 and 1.17.1 I can't even find the string "isSolidThere" anywhere in the mapping files, so I'm very confused about what's going on here.

Could you provide a minimal reproduction example (for example a pom and some code which causes this issue) so I can investigate further?

Alvinn8 commented 3 months ago

Sorry, it seems those logs are missing a space. I think the actual method name in question is isSolid :p

DerEchtePilz commented 3 months ago

Sure, my pom.xml is this: https://pastes.dev/g1KhPFM71e. It's just the module name that says 1.17, but as far as I know, Paper didn't even publish the dev bundles before 1.17.1

I set this up as outlined in the README.md so I am really confused what's going on.

Sorry, it seems those logs are missing a space. I think the actual method name in question is isSolid :p

Yeah, that's what I suspected as well, but I provided these logs as I got them :D

DerEchtePilz commented 3 months ago

Uhh, sorry to be that person, but did you have time to investigate or should I wait a bit longer?

Alvinn8 commented 3 months ago

Sorry, I forgot to reply. I looked into it briefly a few weekends ago but didn't find anything. Right now debugging issues with old Minecraft versions unfortunately isn't very prioritized on my list of things I want to do in my free time. I'll see if I feel like spending some more time on this issue later during the summer when I have a bit more time to spare.

If you or someone else feels like spending some time debugging why this happens or is able to find a fix that would be great!