AlwinEsch / web.browser.chromium

Google Chromium based web browser for Kodi
Other
46 stars 12 forks source link

[ERROR] Build addon web.browser.chromium Web.h #3

Open SIP-Online opened 5 years ago

SIP-Online commented 5 years ago

Hello, It's been a few days that I'm working on setting up your addon web.browser.chromium, on a LibreELEC aarch64 Wayland environment (I will test later on a DRM/GBM). CEF 36610bd 2018-12-11 is well compiled in Wayland ozone, after several attempts of compilations, and the establishment of several patches.

Now I have to compile your addon, and here is the drama to make it compatible under "Kodi 18 RC2". 😥 I had to remove the GeolocationPermission support from your addon because CEF3 does not support it anymore : https://bitbucket.org/chromiumembedded/cef/commits/ac86b61

I then have errors on the absence of the header file AudioEngine.h, after research, Team Kodi preferred to withdraw it, he speaks of you here : https://github.com/xbmc/xbmc/pull/13723 So I will have to delete it too. 😞

I contact you, because I find myself with an absent header, and I do not know if it is official with Kodi : ../src/addon/WebBrowserClient.h:35:10: fatal error: kodi/addon-instance/Web.h: No such file or directory

Do you remember where this file came from, or if a patch is needed ?

Looking forward to seeing you, I'll see you soon !

AlwinEsch commented 5 years ago

This addon is still in development, Now had time and energy to keep going. It also needs some changes to Kodi, which unfortunately are still largely local to me.

I'm watching it at the latest, to have the next Kodi DevCon ready.

With the request https://github.com/xbmc/xbmc/pull/13723 the required audio support has been removed. But this will come back again. The rest for Web addon is not added to Kodi yet.

Furthermore, if I have it stable under my x86_64 Linux it has to be extended to the other OS and CPU's where ARM will be difficult (but will be possible).

With the DRM I have added something with the last commits and ran with me, only one user (at the moment) has to add the libwidevinecdm.so. Bildschirmfoto vom 2019-04-08 01-31-41 (Becomes shown on first initial start of addon)

SIP-Online commented 5 years ago

Hello, Nice to read you, and see that the motivation is back. That's what I noticed, when I tried to make compatible your codes on Kodi 18, I quickly give up, when I saw the mass of work that it represented, as well as your patch that includes in other, the file Web.h. What totally challenged me is that CEF was not yet ready to run on Wayland, but that seems to be resumed since January 2019 : https://bitbucket.org/chromiumembedded/cef/issues/2296/linux-add-ozone-mus-support-as-an

Despite this progress, I turned to WPE, lighter, and can work perfectly on a Raspberry Pi 3. Admittedly, it will not look like your project, which is 100% better in terms of use, but it is the only solution, which will allow me to guarantee a reliable result, and above all compatible on a large choice of mini pc, by its advantage of being much lighter in CPU/Memory resource. For some months, they have released QtWPE, which opens the possibility of building a web browser under WPE : https://github.com/Igalia/meta-webkit/tree/master/recipes-qt/qt-wpe-simple-browser/files

I've been talking with @chewitt for a long time, and the future of LibreELEC is turning to DRM/KMS graphics solutions.

Aware that this is a huge job, if you are ready to question the choice of an Embedded Web, I am ready to work with you on the hardware compatibility part X86/64, ARM ARM64.

oldium commented 5 years ago

WPE - https://wpewebkit.org, WPEQt info - https://base-art.net/Articles/introducing-wpeqt-a-wpe-api-for-qt5/

AlwinEsch commented 5 years ago

Maybe also an alternative with WPE :-D

Have uploaded the Kodi changes: https://github.com/AlwinEsch/kodi/tree/add-webbrowser-support Is still ugly and not complete, if used must be after enable of webbrowser addon the Kodi restarted to have addon working.

The build of addon is mostly identical to other binaries. Also becomes Chromium now direct build by them (maybe later back to binaries who becomes loaded from web during addon build).

The biggest difference on the build by them is, that the make call starts the chromium download, by the use of this GN architecture and the lot of linked repos to Chromium is a standard addon depends build not possible (maybe in future a way).

On this screenshot also a nice feature what it bring (added to this for Test Purpose): Bildschirmfoto vom 2019-04-13 02-24-05

Here the skin code: https://github.com/AlwinEsch/kodi/blob/add-webbrowser-support/addons/skin.estuary/xml/DialogFavourites.xml#L74:L82 With them can be Kodi or a addon add a control to skin which can contains html content, maybe nice for some addons.

AlwinEsch commented 5 years ago

@SIP-Online have looked a bit more to WPE, it seems also be usable, but seen also that it not bring Direct X for WIndows, only Wayland and GL.

Maybe this can be used in future as alternative browser addon.