search

Alxandr / SpotiFire

A project to make a SpotifyClient in C#
http://nudoc.azurewebsites.net/SpotiFire
40 stars 19 forks source link

AlbumBrowse won't complete #10

Closed ChrisBrandhorst closed 12 years ago

ChrisBrandhorst commented 12 years ago

AlbumBrowse seems to be broken. All pointers seem to be set correctly, but the complete call is never made. The result of Error stays on IS_LOADING indefinitely.

Also because of this, the extension IAlbumBrowse#WaitForCompletion never returns.

Alxandr commented 12 years ago

As far as I can see, it's never registered to run at all. At least not in the AlbumBrowse.cs-file. Now, I didn't make it, so I haven't looked into it that much, but I'll see if I can deduct the problem and solve it.

ChrisBrandhorst commented 12 years ago

"As far as I can see, it's never registered to run at all." --> what do you mean by that?

And I know you didn't make it, 'cause I did :-) I just for the life cannot figure out what's wrong... I took the struture of the ArtistBrowse (which functions correctly) and created the AlbumBrowse on that basis. Entrypoint is SpotifyLib.Album#Browse.

Alxandr commented 12 years ago

Yeah, I saw. I'm looking at it now, and also changing the API a tiny bit. I got AlbumBrowse working on my part (about to test ArtistBrowse).

ChrisBrandhorst commented 12 years ago

Nice one, thanks (also for the upgrade to API v9). Working good now.

Alxandr commented 12 years ago

Btw: I hate the "Comment & Close" button in github issues xD. I always hit it wrongly. That's why I keep closing and opening issues like this :).