search

Alxandr / SpotiFire

A project to make a SpotifyClient in C#
http://nudoc.azurewebsites.net/SpotiFire
40 stars 19 forks source link

Missing/unimplemented ArtistBrowse properties #44

Closed brianavid closed 10 years ago

brianavid commented 10 years ago

ArtistBrowse class has PortraitIds, Tracks, SimilarArtists all explicitly throwing NotImplementedException.

In addition, ArtistBrowse::Albums is missing altogether - see sp_artistbrowse_album and sp_artistbrowse_num_albums in https://developer.spotify.com/docs/libspotify/12.1.45/group__artistbrowse.html

Unfortunately, these are members that I need for my project :-(

Alxandr commented 10 years ago

I think I can have them done within a week, hope your not in too much of a hurry. On Aug 4, 2013 12:30 PM, "brianavid" notifications@github.com wrote:

ArtistBrowse class has PortraitIds, Tracks, SimilarArtists all explicitly throwing NotImplementedException.

In addition, ArtistBrowse::Albums is missing altogether - see sp_artistbrowse_album and sp_artistbrowse_num_albums in https://developer.spotify.com/docs/libspotify/12.1.45/group__artistbrowse.html

Unfortunately, these are members that I need for my project :-(

— Reply to this email directly or view it on GitHubhttps://github.com/Alxandr/SpotiFire/issues/44 .

brianavid commented 10 years ago

Thank you,

I am certainly on no hurry, as I have much work to do on the client/UI side.

Meanwhile I shall attempt to add the missing methods on my own - mainly for the experience of the process. I shall leave the definitive fix to you unless you would prefer a pull request from a GitHub novice!

Best regards

Brian

On 4 August 2013 11:35, Alxandr notifications@github.com wrote:

I think I can have them done within a week, hope your not in too much of a hurry. On Aug 4, 2013 12:30 PM, "brianavid" notifications@github.com wrote:

ArtistBrowse class has PortraitIds, Tracks, SimilarArtists all explicitly throwing NotImplementedException.

In addition, ArtistBrowse::Albums is missing altogether - see sp_artistbrowse_album and sp_artistbrowse_num_albums in

https://developer.spotify.com/docs/libspotify/12.1.45/group__artistbrowse.html

Unfortunately, these are members that I need for my project :-(

— Reply to this email directly or view it on GitHub< https://github.com/Alxandr/SpotiFire/issues/44> .

— Reply to this email directly or view it on GitHubhttps://github.com/Alxandr/SpotiFire/issues/44#issuecomment-22069660 .

brianavid commented 10 years ago

Just in case it helps, my (now working) source for the new methods are in http://www.brianavid.co.uk/xfer/Artistbrowse.zip

I would rather let you get it from there and merge it manually than try the unfamiliar (to me) proper GitHub mechanisms.