search

Alxandr / SpotiFire

A project to make a SpotifyClient in C#
http://nudoc.azurewebsites.net/SpotiFire
40 stars 19 forks source link

Updated NuGet dependencies and fixed occasional Exception #57

Closed NeoLegends closed 9 years ago

NeoLegends commented 9 years ago

Occasionally, SpotiFire will thrown an InvalidOperationException while trying to set the login TaskCompletionSource's result. The call to SetResult was replaced with TrySetResult to prevent the errors.

Also updated the outdated NuGet dependencies. (This is why there are so many changes, there were lots of changes in the XML doc. I suggest .gitignoring the packages-Folder and removing all of its traces via BFG repo cleaner to reduce the size of the repo)

NeoLegends commented 9 years ago

I'll mail you the new NuGet package files, if required. :)

Alxandr commented 9 years ago

So, as you've probably realized, I'm working on a bunch of projects that isn't SpotiFire ATM, and at the same time also trying to balance studies. So if you'd like, I can just add you as collaborator, and give you write history to the repository (and nuget.org package). It would allow you to develop along with your needs. I still have plans for SpotiFire, I know where I want to take it, I just have a lot of stuff with higher priorities, so getting another developer who wants to wotk on it (at least for the time being, while you develop with it) would just be great :).

NeoLegends commented 9 years ago

Yes, why not. :)

I'd need to know the direction you want to take it to, though.

NeoLegends commented 9 years ago

Wait! Don't merge. It seems like changing SetResult to TrySetResult causes a deadlock, for whatever reason. (at least within my application) It might also be the new dependencies, I'll have to check that, too.

Don't merge until that is fixed, please. :)

Alxandr commented 9 years ago

Could you join me at https://gitter.im/Alxandr/SpotiFire at some point?