Fixed async handling in Session::Relogin

Alxandr / SpotiFire

A project to make a SpotifyClient in C#

http://nudoc.azurewebsites.net/SpotiFire

40 stars 19 forks source link

Fixed async handling in Session::Relogin #62

Closed NeoLegends closed 8 years ago

NeoLegends commented 8 years ago

I made a small test project and indeed, other than I previously thought, Session::Relogin asynchronously calls the login callback after the user has been logged in. It synchronously returns on error, though. See #61.

NeoLegends commented 8 years ago

So, are we going to merge this now?

Alxandr commented 8 years ago

Oh, yeah, sure. Sorry forgot about this :P.

Don't you have merge rights?

NeoLegends commented 8 years ago

Yes I do, but I thought I'd get your voice on that before merging. :D

Since my Surface has had a power button failure and I sent it to Microsoft, I won't be able to push the binaries to NuGet just yet. I expect that thing to arrive tomorrow or on monday.