search

AlynxZhou / alynx-live-wallpaper

An android app that allows you choose a video as wallpaper.
https://livewallpaper.alynx.xyz/
Apache License 2.0
94 stars 37 forks source link

Bug: when video resolution has a width that's larger than current screen width, scrolling doesn't do anything #21

Open AndroidDeveloperLB opened 2 years ago

AndroidDeveloperLB commented 2 years ago

This occurs a lot, as most videos are oriented horizontally, and yet smartphones are often oriented vertically. I scroll and nothing occurs. I can't see the rest of the video that was chosen.

Got the sample video file from here:

https://www.webmfiles.org/demo-files/

AlynxZhou commented 2 years ago

Uploading scrcpy_2022-02-20_14-51-39.zip…

You just click Comment before your file finished uploading...

You may try the options in app menu, which makes it scroll video when you scroll your launcher.

However if you are asking for a "crop" function that let you to choose which part of video will display...the answer is simple NO. I don't want to add a crop UI in this app because I am a Linux desktop dev and Android UI is a horrible thing...and adding another library is too complex for this app.

AlynxZhou commented 2 years ago

My advice is just simply crop your video files on PC and then copy it to your phone.

AlynxZhou commented 2 years ago

If you still have question about why you cannot scroll video when preview, because the preview UI is part of your Android system, it's designed in this way.

AndroidDeveloperLB commented 2 years ago

I'm not talking about preview. It's right on the launcher. I'm not talking about cropping either, because I wrote about scrolling. The video doesn't scroll when you scroll. You can't see the rest of it. Only a the portion of it, in the center.

As for the option, I actually missed it, but still: It has a bug, as it will still not be able to view the entire video. Look how many pages I've created on Pixel launcher, and I still can't see all of the video (you can see by the text being cut) :

scrcpy_2022-02-20_15-29-13.zip

The video resolution is 640x360 , my device is Pixel 4 so its resolution is 1080x2280 . If you divide the heights, you get ~6.33 . So the stretched video resolution would be ~4053.33x2280. If you divide 4053 by 1080, you will get that I need ~3.75 pages. How could it be that having 7 pages on the launcher (I've added more and more as I didn't see it show the entire video content), I still can't see the entire video content?

AlynxZhou commented 2 years ago

As for the option, I actually missed it, but still: It has a bug, as it will still not be able to view the entire video. Look how many pages I've created on Pixel launcher, and I still can't see all of the video (you can see by the text being cut) :

Yes, it does have some issues on calculating offset, I didn't come up a better way because I only use screen ratio videos, you may check this function https://github.com/AlynxZhou/alynx-live-wallpaper/blob/master/app/src/main/java/xyz/alynx/livewallpaper/GLES30WallpaperRenderer.java#L293 and modify it to fix this problem.

AlynxZhou commented 2 years ago

I don't have Android Studio on this computer, let me try to do some fix, but it may not work, though.

AndroidDeveloperLB commented 2 years ago

Thank you!

AndroidDeveloperLB commented 2 years ago

@AlynxZhou Can you please try again?

Also, are you the creator of this live wallpaper? Can I perhaps donate you to make some specific upgrades to the app (either here or somewhere else) ?