search

AlyxMoon / lunar-factorio-mod-manager

A mod manager for Factorio, programmed using the Electron framework.
MIT License
6 stars 2 forks source link

Add search to mods portal #100

Closed mrdejong closed 4 years ago

mrdejong commented 4 years ago

This pull request adds the ability to search the mod portal. Going threw 2000+ mods manually is a bit, lets say bad for lazy people!

Also minor change to profile view, making the activated mods list scrollable (sorry for not putting this in its own branch.).

AlyxMoon commented 4 years ago

Hey, I appreciate the pull request!

You beat me to the next feature I was going to work on but I've got no complaints as I've been distracted with other things and I've let the project just sit around.

Anyhoo, looks like it's working well. If you don't mind I have a few edits to suggest. If you wouldn't mind adding that into the PR that would be awesome, otherwise no sweat I can add it in after I pull it. I'll make note in the file review tab.

mrdejong commented 4 years ago

Hey @AlyxMoon,

I have made the changes you suggested. I'm not happy with how the page count get changed since I have to filter & search for a second time to get the count. I will search for a different solution in a other branch later :) .

Also is there a way to discus this project on a different platform then github, maybe something like discord?

AlyxMoon commented 4 years ago

Awesome, thanks for the updates. Things look good.

I will add back in the yarn.lock being a part of the tracked files though, as the yarn docs states that should be the way it's used. I often have that change what feels unnecessarily so I need to figure out a bit more how yarn works anyhow.

I did add a room in my Discord channel, you're welcome to bring up any discussion there. Be warned though, I'm not very active on things right now in life. But I will make an effort to respond if you leave a message :) https://discord.gg/D7BtACq