Fix: app crash if fails to read any mod file

AlyxMoon / lunar-factorio-mod-manager

A mod manager for Factorio, programmed using the Electron framework.

MIT License

6 stars 2 forks source link

Fix: app crash if fails to read any mod file #144

Closed AlyxMoon closed 4 years ago

AlyxMoon commented 4 years ago

From a message on the Factorio forum post: (https://forums.factorio.com/viewtopic.php?p=491002#p491002)

Hi!)
I've got a crash...

error-log – https://www.dropbox.com/s/x2qwhuu6xkfv2 ... g.txt?dl=0
info-log – https://www.dropbox.com/s/ckjrjraxiuqqu ... g.txt?dl=0

I'd suppose the reason may be my special path names (_STEAM_, _MODS_, _Game Utils_).

AlyxMoon commented 4 years ago

After troubleshooting I found it was just an error with a corrupted zip file. However, failing to read a mod shouldn't be a complete failure state. The app should be able to continue in the event of a bad mod file.

AlyxMoon commented 4 years ago

Corrected this behavior with release 2.3.0