search

AlyxMoon / lunar-factorio-mod-manager

A mod manager for Factorio, programmed using the Electron framework.
MIT License
6 stars 2 forks source link

Fixed the promises #85

Closed Danacus closed 7 years ago

Danacus commented 7 years ago

I think this is a better way to use promises. I've tested it by clearing the storage and see if it builds new configs. It works perfectly, but I think it did so before too, so it's not very important.

AlyxMoon commented 7 years ago

I'm all for swapping to a better way of handling things. I'll take it.

As a small note, more descriptive commit messages would be appreciated. It's something I've been bad about in the past but didn't have to worry about since I knew the changes I made personally. But something more like 'changed ProfileManager methods to use promises instead of callbacks' would help me when I'm glancing through the commits.

Danacus commented 7 years ago

Ok, I'll do that on the next commits. Have you already seen the changes I'm making on ModManager? https://github.com/Danacus/Lunars-Factorio-Mod-Manager/pull/3