Changed all Callbacks in ModManager to Promises

AlyxMoon / lunar-factorio-mod-manager

A mod manager for Factorio, programmed using the Electron framework.

MIT License

6 stars 2 forks source link

Changed all Callbacks in ModManager to Promises #86

Closed Danacus closed 5 years ago

Danacus commented 7 years ago

It works now, but there is are some problems with the UI.

The text message below when downloading mods appears when downloading the first mod, but then it slowly disappears after some seconds. Whenever I download a new mod, the message doesn't become visible again.
The installation status of the mods in the online mod list doesn't update when downloading a mod, but it does update in the installed mods tab and the profiles tab.

I don't know if it's a big problem that the UI isn't working correctly, since you're rewriting it.

Danacus commented 7 years ago

I fixed the bugs. Maybe it's not the most proper way to fix it, but at least everything is working now.

Danacus commented 7 years ago

You can skip this pull request and go to #87 or #88 instead, or merge this one and close the others (#87 and #88) without merging them if you don't like them.

AlyxMoon commented 7 years ago

Sure, I'll give a more concrete response once I've had a chance to look through the code.

Danacus commented 7 years ago

Ok, that's fine. Don't hurry, take your time and take a look whenever you want.

Danacus commented 7 years ago

Actually I don't really care what you do with my pull requests, as long as I'm not bored it the holidays, it's fine for me. I'm just learning a lot right now, just by trying to "contribute".

AlyxMoon commented 5 years ago

Well, this has been open a long while.

I'm planning on reworking the app so I'll be closing this and the issues. I remember being pretty unhelpful and a bit of a jerk about you wanting to assist back in the day, so my apologies about that.