search

Alzymologist / Kalatori-backend

Kalatori daemon to handle chain-to-webstore interaction
GNU General Public License v3.0
0 stars 6 forks source link

ci: init #12

Closed Slesarew closed 2 months ago

Slesarew commented 2 months ago

usual stuff we'll put into mandatory checks as always

kirushik commented 2 months ago

Can we please also have an additional check that you can't merge into main without bumping at least the patch version?

As per request by @lleokaganov, seems super-useful for debugging

Slesarew commented 2 months ago

@kirushik This would not work for building off-main branch, which is probably even more problematic case, maybe we just concat git commit hash to health response and everywhere else where this is relevant in github builds until we start putting this on crates?

Slesarew commented 2 months ago

https://crates.io/crates/git-version maybe

kirushik commented 2 months ago

I probably don't understand the problem?

yeah; I mean we'll start testing on side branch and things break again. So:

that's how I understand this. If the (2) is not the case, then we should just always pin reported version with commit hash. These artifacts in development too often end up generated off-main to rely on this - and once we have CI check, we would rely on it and get in silly trouble.