search

Alzymologist / Kalatori-backend

Kalatori daemon to handle chain-to-webstore interaction
GNU General Public License v3.0
0 stars 6 forks source link

chore: fixed all the minor Clippy rants #14

Closed kirushik closed 2 months ago

kirushik commented 2 months ago

As a preparation for #12 being merged

kirushik commented 2 months ago

I still find https://github.com/Alzymologist/Kalatori-backend/blob/5ba7f4db5faad3baff183058eaf88ee6856a2c0b/src/database.rs#L316-L325 and https://github.com/Alzymologist/Kalatori-backend/blob/5ba7f4db5faad3baff183058eaf88ee6856a2c0b/src/rpc.rs#L466-L488 suspicious, and would've preferred this would be a more concise logic.

Consumer asked for invoices()? Give them an Iterator over all the properly parsed elements in the db.

Slesarew commented 2 months ago

we can merge #12 first to make sure this passes; branch protection rules are not set yet.

Slesarew commented 2 months ago

Is this redundant with #18?

Slesarew commented 2 months ago

ok it is deprecated I suppose