AmProsius / gothic-1-community-patch

Gothic 1 Community Patch
Other
48 stars 4 forks source link

Dialogue option not available. #267

Open Quintus24 opened 2 years ago

Quintus24 commented 2 years ago

Hello, everyone, Merry Christmas!

I would like to report the following bug:

Describe the bug: This issue can be encountered in the Swamp Camp if the user starts the "The Swampweed Harvest" quest. During the quest, NPC "Balor" will offer the user an opportunity if he pays 50 Ore. This behavior will unlock NPC "Cipher" as a trader in the New Camp and will allow the player to get "50 Swampweed" items again, after a number of days, from NPCs "Viran" and "Balor", even after the quest was completed. However, NPC "Balor" cannot fulfill this request because the user does not have a "Ok, here is 50 Ore as an advance payment." dialogue option in the dialogue box.

Expected behavior: The user has a dialogue string which will allow him to pay the "50 Ore" again and receive "50 Swampweed" from Balor.

Steps to reproduce the issue:

  1. Initiate and progress through the "The Swampweed Harvest" quest.
  2. Convince NPC "Balor" to reveal his contact in the New Camp by paying him "50 Ore".
  3. Complete "The Swampweed Harvest" quest.
  4. Go to the"New Camp and talk with NPC "Cipher" about the deal.
  5. Return to the Swamp Camp after a few days.
  6. Talk with NPC "Viran" and receive "50 Swampweed" again.
  7. Travel to the PATH_TAKE_HERB_06 waypoint and talk with NPC "Balor".
  8. Ask him about the swampweed and listen to what he has to say about the advance payment.
  9. Notice there is no "Ok, here is 50 Ore as an advance payment." dialogue option in the dialogue box.

Additional context

Kindly note that this issue triggers only if you convince Balor to reveal his contact in the New Camp.

Full dialogue between Me and Balor after completing the "The Swampweed Harvest" quest: Select: I'm to pick up the next delivery for Cor Kalom. Me: It's me. I'm Back. I'm to pick up the next delivery. Balor: Of course! To sell it off to the New Camp again? Balor: I wanna see 50 Ore, my usual advance payment.

No issues encountered with NPC "Viran", he will give you "50 Swampweed" items after a few dialogue lines.

I'm not sure exactly how many days are required to pass for each "harvest" and "delivery" to reset. Probably after 3-4 days, the process can be repeated, over 25 days passed before I noticed this issue.

Attaching some screenshots for more clear information.

  1. NPC "Balor" location at PATH_TAKE_HERB_06 waypoint. Balor Location @ PATH_TAKE_HERB_06

  2. Dialogue Part 1. Balor Part 1

  3. Dialogue Part 2. Balor Part 2

  4. Dialogue Part 3. Balor Part 3

  5. Dialogue Part 4. Balor Part 4

  6. Dialogue Part 5. No option available in the dialogue box. Balor Part 5 - No Option

  7. Example with NPC "Viran" (Part 1). Viran Part 1

  8. Example with NPC "Viran" (Part 2). Notice the "50 Items received!" string. Viran Part 2

Thank You and Best Regards! Quintus24

AmProsius commented 2 years ago

Thanks for reporting! You're right, there seems to be a missing dialog here: https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_NOV_1304_Balor.d#L217-L232

I don't know yet how to fix it properly without a solution that's too opinionated.

szapp commented 2 years ago

I see two hurdles to overcome:

  1. The problem can potentially be fixed in various ways (e.g. new dialog instances unlocked after that dialog or dialog sub-choices within that dialog). All of these need to be checked at runtime, because a mod might have already fixed it in one of these ways.
  2. It has to be checked whether the cost is really 50 ore or whether mod may have changed the price.

I have a question: @Quintus24 you write “..the process can be repeated..”. Do you mean the faulty dialog can be triggered multiple times over and over to continuously receive more and more swampweed? From the scripts that second time should only be available once. After the dialog is triggered it should never be available again.

Quintus24 commented 2 years ago

Hi, @szapp,

I apologies for that confusing description, but yes, I was speculating that it could be repeated after a certain period of time. I assumed that the quest becomes "repeatable" after unlocking Cipher, therefore, the issue might be triggered again. I have not tested the theory yet, that's why I mentioned the "process can be repeated".

I may be confused because I already completed the quest, which gave me 100 swampweed in total. Much later in the game I got another 50 swampweed after I stumbled on Viran again and shortly after I noticed the issue with the dialogue option from Balor.

So if the scripts are set to trigger that dialogue only once, it means I was wrong and it's not repeatable. Unless the changing of Chapters might somehow affect this.

Regards, Quintus24