search

AmProsius / gothic-1-community-patch

Gothic 1 Community Patch
Other
49 stars 4 forks source link

Lee's subtitles don't match the audio (EN) #274

Open Quintus24 opened 2 years ago

Quintus24 commented 2 years ago

Hello, everyone!

I would like to report the following bug:

Describe the bug: The issue can be encountered in the New Camp after completing the "Admission to the New Camp" quest. If the user asks NPC "Lee" about joining the mercenaries, he can be heard saying, in EN: "I'll give you a chance. How about it?" However, the subtitle is displayed in DE as: "Ich gebe dir eine Chance. Wie siehts aus?"

Expected behavior: The subtitles of the conversation with Lee after completing the quest "Admission to the New Camp" now match the audio.

Steps to reproduce the issue:

  1. Initiate and complete the "Admission to the New Camp" quest.
  2. Travel to the NC_SMALL_CAVE_CENTER waypoint and talk with NPC "Lee".
  3. Select the "I'd like to become a mercenary of the mages - am I ready yet?" dialogue option.
  4. Notice the reply is spoken in EN and the subtitle is displayed in DE.

Additional context My version of the game is in English. The spoken dialogue is correct, no audio mismatch observed.

Attaching some screenshots for more clear information.

  1. Initiate conversation. Start Conversation

  2. EN subtitle. Dialogue 1 EN

  3. DE subtitle. Dialogue 2 DE

  4. Location at NC_SMALL_CAVE_CENTER waypoint. Location @ NC_SMALL_CAVE_CENTER

Thank You and Best Regards! Quintus24

szapp commented 2 years ago

Relevant output unit:

https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_SLD_700_Lee.d#L166

AmProsius commented 2 years ago

See #278.

szapp commented 2 years ago

Just as a few notes, since #278 is a bit special as it is an SVM and not a dialog. For dialogs it will be like this.

  1. The name of the OU is found in the AI_Output command. Here, e.g. it is Sld_700_Lee_BECOMESLD_Info_08_04.
  2. A suitable function name for the fix may be G1CP_274_EN_LeeAdmissionOu. This way it is consistent with fix names like G1CP_031_WolfPlateDialog, i.e. [NPCname] [Context] [Modality].
  3. Content-wise the fix should be the same for both SVM OU or dialog OU.