AmProsius / gothic-1-community-patch

Gothic 1 Community Patch
Other
49 stars 4 forks source link

NPC bodies in the Free Mine lose their "Ranged Weapons" in Chapter 4. #285

Open Quintus24 opened 2 years ago

Quintus24 commented 2 years ago

Hello, everyone!

I would like to report the following bug:

Describe the bug: This issue can be encountered in the Free Mine after starting Chapter 4. All of the NPC that previously had Ranged Weapons in their inventory no longer have them in Chapter 4. This occurs when the Free Mine is attacked and everyone is killed.

Expected behavior: The NPC bodies that previously had Ranged Weapons will continue to have them in Chapter 4.

Steps to reproduce the issue:

  1. Travel to the Free Mine and notice that most of the NPC have Ranged Weapons.
  2. Progress through the game and reach Chapter 4.
  3. Travel to the Free Mine and notice that everyone has been killed.
  4. Loot the bodies and notice that all of them are missing their Ranged Weapons from their inventories.

Additional context It can be noticed that the NPC bodies still have their Arrows even if they no longer have any Ranged Weapons. All of the NPC Rogues, Mercenaries and Okyl have this issue. Other items such as Food, Potions and Melee Weapons don't seem to be affected. In Chapter 4, the NPC are dead, this is intended according to the story, as the Free Mine falls under attack by the Old Camp. This is a rather strange bug, unless it's actually intended for the sake of game mechanics, maybe.

Attaching some screenshots for more clear information, before and after Chapter 4.

  1. NPC "Okyl" - Missing "Ranged Weapon", Chapter 4. Okyl - No Ranged Weapon in CH4

  2. NPC "Mercenary" - Missing "Ranged Weapon", Chapter 4. Mercenary - No Ranged Weapon in CH4

  3. NPC "Rogue" - Missing "Ranged Weapon", Chapter 4. Rogue - No Ranged Weapon in CH4

  4. NPC "Okyl" alive. Okyl

  5. NPC "Mercenary" alive. Mercenary

  6. NPC "Rogue" alive. Rogue

  7. NPC "Okyl" - Before Chapter 4. Okyl - Longbow before CH4

  8. NPC "Mercenary" - Before Chapter 4. Mercenary - Longbow before CH4

  9. NPC "Rogue" - Before Chapter 4. Rogue - Longbow before CH4

Thank You and Best Regards! Quintus24

szapp commented 2 years ago

This is partially intended. Equipped weapons of NPCs, when killed off through story events[1], are removed[2]. The purpose was, on the one hand, to avoid exploits, and on the other hand, I think there was a technical reason, too.

What is odd, however, is that the primary weapon is not removed here. I would like to follow up on how things are processed. It may have to do with the fact, that the NPCs in question are out of AI range when they are killed of. One easy way to check this, would be to trigger the function[1] (the Workaround Helper is useful to call Daedalus functions from the console), while the PC is in close proximity to the NPCs.

[1] https://github.com/AmProsius/gothic-1-community-patch/blob/2892a60a3edf33340d7907fe7b3c137d079e8474/scriptbase/_work/Data/Scripts/Content/Story/Chapters/B_Story_FmTaken.d#L1-L51

[2] https://github.com/AmProsius/gothic-1-community-patch/blob/2892a60a3edf33340d7907fe7b3c137d079e8474/scriptbase/_work/Data/Scripts/Content/AI/AI_Intern/B_Functions.d#L393-L424