AmProsius / gothic-1-community-patch

Gothic 1 Community Patch
Other
50 stars 4 forks source link

Spelling - Grilled Meat (EN) #338

Open Quintus24 opened 2 years ago

Quintus24 commented 2 years ago

Hello, everyone!

I would like to report the following bug:

Describe the bug: The "Grilled meat" item is spelled with a lower case "m" for the word "meat".

Expected behavior: The "Grilled meat" item is spelled as "Grilled Meat" with an upper case "M".

Steps to reproduce the issue:

  1. Obtain a "Raw Meat" item from an animal.
  2. Cook the meat using a Pan.
  3. Open the inventory and notice the "Grilled meat" item.

Additional context Minor issue, low prio. Not sure what the general grammatical rule is for such a case, but it seems that most items in the game that contain two or more words in their name are spelled with an upper case first letter. Note that the "Raw Meat" item, for example, is spelled as such.

Attaching screenshots for more clear information.

  1. "Grilled meat" @ Inventory. Grilled Meat @ Inventory ory.

  2. "Raw Meat" @ Inventory. Raw Meat @ Inventory

  3. "Grilled meat" in the World. Grilled Meat in World

Thank You and Best Regards! Quintus24

AmProsius commented 2 years ago

https://github.com/AmProsius/gothic-1-community-patch/blob/8e6b8fa5c1a4a75774647a32fa5ef9ca7f614daa/scriptbase/_work/Data/Scripts/Content/Items/Food.d#L159-L175

changed to

 INSTANCE ItFoMutton (C_Item) 
 { 
     name                =   "Grilled Meat"; 

     mainflag            =   ITEM_KAT_FOOD; 
     flags               =   ITEM_MULTI; 

     value               =   Value_Fleisch; 

     visual              =   "ItFo_CookedMutton_01.3ds"; 
     scemeName           =   "MEAT"; 
     on_state[0]         =   UseMutton; 

     description         = name; 
     TEXT[1]             = NAME_Bonus_HP;                COUNT[1]    = HP_Fleisch; 
     TEXT[5]             = NAME_Value;                   COUNT[5]    = Value_Fleisch; 
 };
m0ezes commented 2 months ago

I've noticed the same spelling inconsistency with this item in the German script version too:

name = "gebratenes Fleisch"; (line 161)

and

name = "rohes Fleisch"; (line 185)

Example screenshot: GOTHIC 1 08k_mod 07 09 2024 23_28_30