search

AmadeusITGroup / Redis-Operator

Redis Operator creates/configures/manages Redis clusters atop Kubernetes
MIT License
167 stars 62 forks source link

Add the possibility to overwrite redis-server configuration parameters #19

Closed clamoriniere1A closed 5 years ago

clamoriniere1A commented 6 years ago

Currently, only a few redis-server parameters can be set thru the redis-node parameters and pod-template present in the Redis-Cluster Custom-Resource.

The Idea is to add new Key-Value map field in the Redis-Cluster.Spec (like the Metadata.Labels) That will be used by the redis-node process to configure the Redis-Server process.

gregbacchus commented 6 years ago

Also it may be worth considering putting these into a ConfigMap that gets mounted into the container as a file, rather than having the go code modify the config file inside in the container. This would help take some of the responsibilities out of the container and into existing constructs within kubernetes.

killmeplz commented 6 years ago

https://github.com/AmadeusITGroup/Redis-Operator/pull/23 i'm not sure that i'm getting this right. But you can do that without any interventions into the code

clamoriniere1A commented 6 years ago

@killmeplz sure, but since the redis-node process is already playing with the configuration file, I didn't want to add another process (/bin/cp) in an init-container to do it. in #22 PR I also to the time to re-organize the redis-node process parameter. and to support "read-only root file system" in containers.