Closed clamoriniere1A closed 5 years ago
Merging #22 into master will decrease coverage by
0.06%
. The diff coverage is38.09%
.
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 37.08% 37.01% -0.07%
==========================================
Files 37 37
Lines 3422 3420 -2
==========================================
- Hits 1269 1266 -3
+ Misses 2036 2034 -2
- Partials 117 120 +3
Impacted Files | Coverage Δ | |
---|---|---|
pkg/redisnode/config.go | 0% <ø> (ø) |
:arrow_up: |
pkg/redisnode/node.go | 55% <33.33%> (-5.26%) |
:arrow_down: |
pkg/redisnode/redisnode.go | 26.73% <66.66%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 05fe3c9...22fbd05. Read the comment docs.
I guess you use a configmap to do that. I will do a PR later today
@killmeplz yes the idea is to add a ConfigMap VolumeMount in a RedisCluster.Spec.PodTemplate
and provide the file path in the Volume mountPath
as an argument of the redis-node
container process.
Fixes: #19
Add new
redis-node
option for including redis configuration files in the generated redis-conf file.Files will be added at the end of the default file. like this those additional configuration files will be able to overwrite default values or value already set.