AmadeusITGroup / Redis-Operator

Redis Operator creates/configures/manages Redis clusters atop Kubernetes
MIT License
167 stars 62 forks source link

fix SIGSEGV in checkIfPodNameExistAndIsReused function #28

Closed clamoriniere1A closed 6 years ago

clamoriniere1A commented 6 years ago

In some specific case a "redis.Node"doesn't have its associated Pod in the checkIfPodNameExistAndIsReused function. it results in a segmentation violation.

Fix: add a check if Pod is not set, and ignore the Node in that case.

codecov-io commented 6 years ago

Codecov Report

Merging #28 into master will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   37.08%   37.06%   -0.03%     
==========================================
  Files          37       37              
  Lines        3422     3424       +2     
==========================================
  Hits         1269     1269              
- Misses       2036     2037       +1     
- Partials      117      118       +1
Impacted Files Coverage Δ
pkg/controller/sanitycheck/untrustednodes.go 70.83% <0%> (-3.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5d734c...918c3fa. Read the comment docs.