search

AmadeusITGroup / kassette

kassette is a development server, used mainly for testing, which proxies requests and is able to easily manage local mocks.
MIT License
9 stars 15 forks source link

fix: missing CA option when generating CA certificate #456

Closed divdavem closed 2 years ago

divdavem commented 2 years ago

This PR fixes a regression introduced in 1ec84e5708b00b66db1afb4eb6834c62b4d081c0 ca, which was the last parameter of the createCertificate function, was true by default before that commit, but the default value was lost when refactoring the parameters of createCertificate to accept an object.

codecov[bot] commented 2 years ago

Codecov Report

Merging #456 (80a8ca6) into master (8cfef48) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          35       35           
  Lines        1125     1125           
  Branches      246      246           
=======================================
  Hits         1020     1020           
  Misses         53       53           
  Partials       52       52
Flag Coverage Δ
e2e 78.75% <ø> (ø)
ut 61.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/app/server/tls/impl.ts 43.18% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

divdavem commented 2 years ago

@fbasso Thank you for your review!