search

AmadeusITGroup / kassette

kassette is a development server, used mainly for testing, which proxies requests and is able to easily manage local mocks.
MIT License
9 stars 15 forks source link

fix: invalid generation of tls certificates for IP addresses #457

Closed divdavem closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #457 (e9e320f) into master (a31c692) will increase coverage by 0.06%. The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   90.66%   90.73%   +0.06%     
==========================================
  Files          35       35              
  Lines        1125     1144      +19     
  Branches      246      251       +5     
==========================================
+ Hits         1020     1038      +18     
  Misses         53       53              
- Partials       52       53       +1
Flag Coverage Δ
e2e 78.23% <52.38%> (-0.53%) :arrow_down:
ut 61.45% <76.19%> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/app/server/tls/certs.ts 97.14% <95.23%> (-2.86%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.

divdavem commented 2 years ago

@fbasso Thank you for your review!