search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

fix: additional properties not working for new application or component #1083

Closed fpaul-1A closed 6 months ago

fpaul-1A commented 6 months ago

Proposed change

Fix following issue:

npm create @o3r test cd test npm exec ng g application test-app -- --standalone=false Error: Unknown argument: standalone

Related issues

nx-cloud[bot] commented 6 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f9a9a3ec07d7d9194a57c80497c3f3ad2b9dcae3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 8 targets - [`nx run-many --target=test-int --parallel 2 --output-style=stream`](https://cloud.nx.app/runs/cCkvjAuw88) - [`nx run-many --target=build --projects=eslint-plugin,dev-tools --parallel 3`](https://cloud.nx.app/runs/LjsjqD3VzH) - [`nx run-many --target=publish --parallel 3 --nx-bail --access=public --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873`](https://cloud.nx.app/runs/jjvgqCgd79) - [`nx affected --target=test --parallel 2 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --output-style=stream`](https://cloud.nx.app/runs/ubQxz0AHMt) - [`nx run-many --target=build --parallel 3`](https://cloud.nx.app/runs/VMTr3K7Ipy) - [`nx run ama-sdk-generator-sdk:build-swagger`](https://cloud.nx.app/runs/b5hosDu6Px) - [`nx affected --target=test --parallel 2 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --output-style=stream`](https://cloud.nx.app/runs/kwLc8eCBx2) - [`nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci`](https://cloud.nx.app/runs/FOH4Y3hU4Z)

Sent with 💌 from NxCloud.

kpanot commented 6 months ago

Is it a change in Ng17 that makes the additionalProperty: true ignored by the CLI option validation process? Or did we have an issue before? What's about our other schematics that are supposed to propagate the options to the child Angular schematics?

fpaul-1A commented 6 months ago

Is it a change in Ng17 that makes the additionalProperty: true ignored by the CLI option validation process? Or did we have an issue before? What's about our other schematics that are supposed to propagate the options to the child Angular schematics?

We already have this issue in the current releases We already define all properties for the case of angular components

kpanot commented 6 months ago

Is it a change in Ng17 that makes the additionalProperty: true ignored by the CLI option validation process? Or did we have an issue before? What's about our other schematics that are supposed to propagate the options to the child Angular schematics?

We already have this issue in the current releases

We already define all properties for the case of angular components

I see 😟 Can you then link the issue associated (and/or PR relative to the component and library fix)?