AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
51 stars 39 forks source link

[Bug]: generated otter library contains otter testing and jest #1765

Open vscaiceanu-1a opened 6 months ago

vscaiceanu-1a commented 6 months ago

Package name

workspace

Package version

10.2.1

Reproduction steps

npm create @o3r my-workspace
cd my workspace
ng g library my-lib

Current result

CREATE libs/my-lib/README.md (978 bytes)
CREATE libs/my-lib/ng-package.json (181 bytes)
CREATE libs/my-lib/package.json (1100 bytes)
CREATE libs/my-lib/tsconfig.lib.json (329 bytes)
CREATE libs/my-lib/tsconfig.lib.prod.json (240 bytes)
CREATE libs/my-lib/tsconfig.spec.json (277 bytes)
CREATE libs/my-lib/src/public-api.ts (118 bytes)
CREATE libs/my-lib/src/lib/my-lib.component.spec.ts (590 bytes)
CREATE libs/my-lib/src/lib/my-lib.component.ts (223 bytes)
CREATE libs/my-lib/src/lib/my-lib.service.spec.ts (353 bytes)
CREATE libs/my-lib/src/lib/my-lib.service.ts (134 bytes)
CREATE libs/my-lib/.gitignore (13 bytes)
CREATE libs/my-lib/.npmignore (0 bytes)
CREATE libs/my-lib/jest.config.js (1095 bytes)
CREATE libs/my-lib/tsconfig.builders.json (463 bytes)
CREATE libs/my-lib/tsconfig.json (185 bytes)
CREATE libs/my-lib/testing/setup-jest.ts (42 bytes)
UPDATE angular.json (1341 bytes)
UPDATE package.json (1424 bytes)
UPDATE tsconfig.json (912 bytes)
✔ Packages installed successfully.

Expected result

Nothing linked to jest. Only ng add @o3r/testing should add jest.

Additional comments

No response

vscaiceanu-1a commented 4 months ago

This also applies to SDKs

vscaiceanu-1a commented 3 months ago

There are some skipped integration tests that should be reactivated when fixing this.