search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

[Bug]: Unable to create service using the Generator #1778

Closed gavadhany closed 1 week ago

gavadhany commented 2 weeks ago

Package name

core

Package version

10.2.4

Reproduction steps

Create a simple NX repo Add o3r/core to the repo Add an Nx Angular Library for service Try creating a service in the newly created library using command

"nx generate @o3r/core:service"

Current result

After accepting the inputs, the process hanges

image

Expected result

Service should be created

Additional comments

Did a bit of digging around in the schematics.

It never exits out of the while loop in Index.ts Line 49

image

"tree.exists" isnt working correctly. The third path in the below screenshot exists, but the "tree exists check" is saying false.

image

also path.resolve(destination, rec) !== '/' doesnt work in windows as it ends up returning directory like "C:\" image

Issue appears to be command path.resolve

gavadhany commented 1 week ago

Addressed as a part of https://github.com/AmadeusITGroup/otter/pull/1782