search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

feat: add documentation regarding the placeholder mechanism #241

Closed kpanot closed 1 year ago

kpanot commented 1 year ago

Document for placeholder should not be only in Rules Engine documentation #228

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c41dc768bbc0d8c4aab1340bce5cbe2cc6186bc9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 6 targets - [`nx run-many --target=test-int --parallel 2`](https://cloud.nx.app/runs/LyJ5oYWtGL) - [`nx run-many --target=build --projects=eslint-plugin,dev-tools --parallel 2`](https://cloud.nx.app/runs/qS7271TXMi) - [`nx run-many --target=build --parallel 2`](https://cloud.nx.app/runs/3BkHE9fLqB) - [`nx affected --target=test --parallel 2 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main`](https://cloud.nx.app/runs/mSyp5R8y4h) - [`nx run ama-sdk-generator-sdk:build-swagger`](https://cloud.nx.app/runs/A6gpRWSE45) - [`nx affected --target=lint --parallel 2 --base=remotes/origin/main --configuration ci`](https://cloud.nx.app/runs/G9dLuR26mJ)

Sent with 💌 from NxCloud.

pginoux-1A commented 1 year ago

Document for placeholder should not be only in Rules Engine documentation #228

Did you have a look at https://github.com/AmadeusITGroup/otter/pull/193/files#diff-bc6884ebbf1437dd4007c1584465d156a40ce0613a87adf73c09eeaf178875eb ? Corinne is working on providing documentation for localization key inside placeholders as well. Do you want to regroup it in the same file ?

kpanot commented 1 year ago

Do you want to regroup it in the same file ?

Good point, I think it should be also part of this doc indeed

kpanot commented 1 year ago

Do you want to regroup it in the same file ?

Good point, I think it should be also part of this doc indeed

Documentation regarding the localized template has been added.