search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
51 stars 38 forks source link

feat(cascading): option to bypass non-latest minor branch #2473

Open kpanot opened 1 week ago

kpanot commented 1 week ago

Proposed change

Option to bypass non-latest minor branch on cascading bot

Related issues

- No issue associated -

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c4a10be22ccd6478887df5a77bcdb6af1a42e16e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 11 targets - [`nx run-many --target=test-int --parallel 3`](https://cloud.nx.app/runs/N9COPP8Wbz?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --projects=eslint-plugin --parallel 3`](https://cloud.nx.app/runs/RNt1aT4pOc?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test-e2e --parallel 3`](https://cloud.nx.app/runs/u0YnSbkcDm?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=publish --parallel 3 --nx-bail --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873 --@o3r-training:registry=http://127.0.0.1:4873`](https://cloud.nx.app/runs/8V2UEnBMFu?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=documentation --parallel 3`](https://cloud.nx.app/runs/pZkduHojSE?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel 3 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --collectCoverage`](https://cloud.nx.app/runs/NgZMRIxihb?utm_source=pull-request&utm_medium=comment) - [`nx run ama-sdk-schematics:build-swagger`](https://cloud.nx.app/runs/SKgZwKRD0x?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --parallel 3`](https://cloud.nx.app/runs/9bU0d0Od2R?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel 3 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --collectCoverage`](https://cloud.nx.app/runs/phl0tF8vHl?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci`](https://cloud.nx.app/runs/560g6tlsID?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build-swagger --parallel 3`](https://cloud.nx.app/runs/J6leoBDSgf?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.31%. Comparing base (0042a21) to head (c4a10be). Report is 10 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kpanot commented 1 week ago

Is there a case where we want to skip non-latest minors? Wouldn't this create incoherence and confusion among the different branches / code levels?

Not sure to understand why. As for the policy, we considered the latest minor branches as supported/maintained branches. Which mean that all the other branches are considered as archived (if they are not destroyed). When we cascade, we want to do it only on the considered branched automatically, why would it create "incoherence" to skip unmaintained branches?