AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
51 stars 38 forks source link

chore: upgrade Nx dependencies #2513

Open fpaul-1A opened 1 day ago

fpaul-1A commented 1 day ago

Proposed change

Fork @nx/js:tsc to fix an issue on Windows with Yarn PnP

Related issues

- No issue associated -

nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a799be226c03c2a8e43757c9385366e7f20a4437. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=build --projects=eslint-plugin --parallel 3
✅ Successfully ran 9 targets - [`nx run-many --target=test-int --parallel 3`](https://cloud.nx.app/runs/bLCjKocDZf?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test-e2e --parallel 3`](https://cloud.nx.app/runs/Bn96oNWIDg?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=publish --parallel 3 --nx-bail --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873 --@o3r-training:registry=http://127.0.0.1:4873`](https://cloud.nx.app/runs/bUfl4hL5AR?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --parallel 3`](https://cloud.nx.app/runs/vizTSnjnfs?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci`](https://cloud.nx.app/runs/f9NgSGEL33?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel 3 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --collectCoverage`](https://cloud.nx.app/runs/VjBzPL4dlR?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=documentation --parallel 3`](https://cloud.nx.app/runs/gYczI2rXmk?utm_source=pull-request&utm_medium=comment) - [`nx run ama-sdk-schematics:build-swagger`](https://cloud.nx.app/runs/WFkH8ffBRl?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build-swagger --parallel 3`](https://cloud.nx.app/runs/rIcoVNXpNC?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 41.02564% with 46 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (c9fe500) to head (a799be2). Report is 11 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ools/@o3r/nx-helpers/src/executors/tsc/tsc.impl.ts 32.72% 37 Missing :warning:
...helpers/src/executors/tsc/lib/normalize-options.ts 57.14% 5 Missing and 1 partial :warning:
...ecutors/tsc/lib/get-custom-transformers-factory.ts 57.14% 3 Missing :warning:
Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

kpanot commented 1 day ago

Seeing this fork and the delay of this blocking issue, do you think we still have interest to rely on this executor instead of running TSC + assets copy manually?