search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
51 stars 38 forks source link

fix(rules-engine): allow custom action in the rulesets schema #2516

Open matthieu-crouzet opened 1 day ago

matthieu-crouzet commented 1 day ago

Proposed change

Today if we create a custom action handler, we can't write a rulesets.json validating the schema exposed.

nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 68eda6bc634402606b88841590a89a2415e0e8f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 11 targets - [`nx run-many --target=test-int --parallel 3`](https://cloud.nx.app/runs/3rKiKxGS2T?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --projects=eslint-plugin --parallel 3`](https://cloud.nx.app/runs/9OhnySU03p?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test-e2e --parallel 3`](https://cloud.nx.app/runs/kHMguiDcNy?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=publish --parallel 3 --nx-bail --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873 --@o3r-training:registry=http://127.0.0.1:4873`](https://cloud.nx.app/runs/x2V9oYUhEz?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=documentation --parallel 3`](https://cloud.nx.app/runs/4RuxXxxl8S?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel 3 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --collectCoverage`](https://cloud.nx.app/runs/JHqDqDjhBc?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --parallel 3`](https://cloud.nx.app/runs/5K8P2y3sgk?utm_source=pull-request&utm_medium=comment) - [`nx run ama-sdk-schematics:build-swagger`](https://cloud.nx.app/runs/ftBdf1RNF9?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel 3 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --collectCoverage`](https://cloud.nx.app/runs/0NhHQKAJbs?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci`](https://cloud.nx.app/runs/9J8W9sIbYw?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build-swagger --parallel 3`](https://cloud.nx.app/runs/BecXoJgIp5?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (1dbf243) to head (68eda6b).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.