search

AmadeusITGroup / otter

The Otter project is a highly modular framework whose goal is to provide a common platform to accelerate and facilitate the development of runtime customizable Angular based Web Applications
https://amadeusitgroup.github.io/otter/
BSD 3-Clause "New" or "Revised" License
51 stars 39 forks source link

[Feature]: Skip ng add run of external packages #691

Open mrednic-1A opened 1 year ago

mrednic-1A commented 1 year ago

Context

Today when running the ng add of an o3r package it will install the needed peer deps of this package and it will try to run the ng add of the peer dependency if exists. In some contexts the ng add of an external package fails. (it happens often for ngrx deps for instance).

Proposal

The proposal is to add an option to the ng add run of the o3r packages to skip the run of the ng add of the external schematics. This option will ne forwarded to the child o3r packages when running the ng add of those ones. To be done for all o3r packages.

UPDATE

This feature is done. TO DO:

pginoux-1A commented 1 year ago

After discussion, we decided to add logging when the ng add of those dependencies is failing.