search

AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request
MIT License
165 stars 82 forks source link

Overview Comment is not being reset with '-Dsonar.stash.comments.reset=true' #119

Open tknerr opened 7 years ago

tknerr commented 7 years ago

I was surprised the -Dsonar.stash.comments.reset=true only resets the earlier comments in the diff, but not the overview comment.

Is this the desired behaviour, or is there something wrong on my side?

I find it surprising at least, and the the README also doesn't mention that it would relate to the diff comments only.

t-8ch commented 7 years ago

@tknerr True, this should also affect the overview comment.

sebastian-r commented 6 years ago

Hi,

do you have an idea when this will be integrated ?

t-8ch commented 6 years ago

I was working on it today. The problem is, that the overview comments has to be requested with a new API endpoint, which we currently don't use. I used this to also implement a generic accessor for paged API endpoints. A first prototype should be done tomorrow.

sebastian-r commented 6 years ago

Awesome, thank you!

t-8ch commented 6 years ago

@sebastian-r Can you take a look at #162?

sebastian-r commented 6 years ago

Hi @t-8ch ,

sorry I am responding so late. Had holiday and trainings. I will have a look at it tomorrow. Thanks already for your engagement :)

t-8ch commented 6 years ago

Hi @sebastian-r,

any updates?

t-8ch commented 6 years ago

@tknerr , Could you also validate this?

tknerr commented 6 years ago

@t-8ch sorry don't have that sonar instance available anymore (different project, different toolchain.... :-/)

tonyfalabella commented 5 years ago

You can look at the change in this PR and manually apply it and build your own jar with the change included: https://github.com/AmadeusITGroup/sonar-stash/pull/162 Unfortunately it was for an older codebase (I believe 1.3.0 and current release is 1.6.0) and as such you'll manually have to apply that fix against the latest codebase you'd like. I've used the fix provided and it works nicely against 1.51.