AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request
MIT License
165 stars 81 forks source link

No issues found in SonarQube 6.3 #121

Closed pedromauriciocosta closed 7 years ago

pedromauriciocosta commented 7 years ago

I had the plugin working fine with SonarQube 6.2. But once I updated to 6.3 it stopped posting any issues. Has anyone encountered this problem?

t-8ch commented 7 years ago

I am not aware of any reports.

t-8ch commented 7 years ago

Can you provide debug logs? (Please remove http credentials)

marcjay commented 7 years ago

I'm seeing this as well, it's because api/resources has been removed in 6.3: https://sonarqube.com/web_api/api/resources

Excerpt from log: GET /sonar/api/resources?resource=XXXXX&metrics=line_coverage&format=json HTTP/1.1 ... Response DefaultHttpResponse(decodeResult: success, version: HTTP/1.1) HTTP/1.1 404

t-8ch commented 7 years ago

So without the coverage feature everything works? This is unfortunate... The other API has only been introduced in 5.4, so it is not available in 5.2 LTS.

kingoleg commented 7 years ago

sonar-stash can support both API, why not?

t-8ch commented 7 years ago

I was mistaken. 5.6 is the LTS. As the plugin will only support 5.6 anyways this will be migrated to the new API.

t-8ch commented 7 years ago

This will also have to wait until the coverage part is split into its own plugin. Currently the sonar ws client needs same maven trickery to work and I'd like to keep this complexity out of the sonar-stash plugin.

pedromauriciocosta commented 7 years ago

Thanks for that. Any idea when could we have a working version?

olafgeibig commented 7 years ago

I just want to install the plugin... So now I'm confused what is working and what is broken. The original post says that issues are not posted, but later on you say that coverage is the problem. Currently I'm not so much interested in the coverage feature as this is already solved for me in our Jenkins pipeline. I rather want that issues are commented on the PR.

t-8ch commented 7 years ago

@olafgeibig Currently the coverage feature is broken on SonarQube 6.3. The rest should work.

michalmikee commented 7 years ago

Maybe this is the same problem: https://github.com/AmadeusITGroup/sonar-stash/issues/120

marcjay commented 7 years ago

@michalmikee I think you're right - the line_coverage issue I was also seeing in the logs might have been a red-herring

marcjay commented 7 years ago

I just tested PR #127 and this also solved the issue for me - I'm now seeing issues showing up in PRs 😄

jannylund commented 7 years ago

Any ETA on releasing 1.3.0? I built with PR #127 as well and finally things work properly.

t-8ch commented 7 years ago

127 Is now in 1.3.0-rc1, please test.

jannylund commented 7 years ago

I can confirm this works properly in 6.3!