search

AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request
MIT License
165 stars 82 forks source link

Report issues with no direct line in the diff view #161

Open t-8ch opened 6 years ago

t-8ch commented 6 years ago

This may happen if the issue is reported on a line, that is not directly involved in the PR

Closes #135 #137

datasmurfen commented 6 years ago

Why isn't this in master yet :) ?

t-8ch commented 6 years ago

Because none of the users confirmed, that this is what they want :-)

datasmurfen commented 6 years ago

Then I will confirm - that this would be nice :)

t-8ch commented 6 years ago

Well, you should confirm that the implementation in this PR is sufficient.

datasmurfen commented 6 years ago

I read through the code, and it seems good 😄 The only comment I have is if it should be a setting, and not forced on all users - maybe? But not sure.

t-8ch commented 6 years ago

Please confirm the implementation.

datasmurfen commented 6 years ago

I am sorry I don't understand - is there a button or so for that?
Or do you want me to writhe: I confirm the implementation :)

t-8ch commented 6 years ago

No, you would have to get the source for this PR, build it, install it in sonarqube, run an analysis, see if it behaves as you expect and then possibly confirm the implementation.

snukone commented 3 years ago

ping