implement resetting of overview comments

AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request

MIT License

165 stars 82 forks source link

implement resetting of overview comments #162

Open t-8ch opened 6 years ago

t-8ch commented 6 years ago

See #119

ghost commented 6 years ago

SonarQube analysis reported 6 issues

6 major

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

StashRequestFacade.java#L397: Remove this unused method parameter "diffReport".

datasmurfen commented 6 years ago

This function should be implemented if it's not 👍

tonyfalabella commented 5 years ago

The sonar.stash.comments.reset feature still does not work in version 1.5.1. I think it broken once Sonar moved to version 7.x. To get the feature to properly work I took what was in this PR and tweaked it a bit to work with the 1.5.1 codebase (since this PR looks to be based on an older version of sonar-stash). I'm not sure if it breaks anything else, but it does in fact fix the reset issue.