Closed pbojan closed 6 years ago
Hi @pbojan ,
sorry for the long time until a response.
In general I like the idea.
I would prefer to change the boolean setting to a numeric setting, specifying the actual number of instances to be reported, defaulting to 0 (or -1
if it is better for the implementation).
What do you think?
It would also be nice to make the filenames into links, but this could be a later addition.
Hey @t-8ch,
Thanks for checking out the PR.
So you mean instead of having the const private static final int MAX_FILES_PER_ISSUE = 25;
we replace is with the config value and if it is 0 we just disable it?
Exactly.
Also, can you indent the list of files so there is a visual distinction?
@t-8ch Most of the discussed changes are now done, please take a look again.
Could you squash the commits? Then I will merge the PR.
Done!
Thanks! :sparkles:
This functionality is useful because inline comments are limited to where the diff only happened but we scan the whole file and in the overview we get the accumulated report of found issues but no way to see where these issues are exactly located. Also there is a config to disable/enable this feature.
Just a preview how it will look like: