search

AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request
MIT License
165 stars 81 forks source link

New Feature suggestion - Include code coverage, and alert if quality gate fail on Pull request #192

Closed datasmurfen closed 6 years ago

datasmurfen commented 6 years ago

New Feature suggestion - Include code coverage, and alert if quality gate fail on pull request.

This is something I miss - today we use: https://github.com/kogitant/sonar-slack-notifier-plugin , but would be better to have this in one place.

t-8ch commented 6 years ago

Hi @datasmurfen, Can you elaborate about "Include Code coverage"? The problem with the quality gate is that is executed asynchronously and has not yet finished when sonar-stash is running. (This is also tracked in #95)

t-8ch commented 6 years ago

Also the quality gate is not run on preview runs (See #95)

datasmurfen commented 6 years ago

Right, could it be possible to get the latest quality gate analysis from the "full" run(not the preview run)? Not sure if that would help, but it's one way to do it, I guess?

t-8ch commented 6 years ago

Well, it could be done, but it would be really confusing. I am strongly -1 on it.

datasmurfen commented 6 years ago

Yea I agree, it would be very confusing.

t-8ch commented 6 years ago

Could you elaborate on the coverage you want to see? There is the coverage evolution plugin. It has a few caveats that are documented its README

datasmurfen commented 6 years ago

I think it would been great to see if your pull request brakes/fix the current quality gate with an comment on what you break.

Must Have

Could have:

t-8ch commented 6 years ago

Ok, so it's also tied to the quality gate. As there is no quality gate available there is not much we can do. This will probably happen at all, because SonarSource is promoting their own (closed, paid) branch and pull request solution.