search

AmadeusITGroup / sonar-stash

Stash (BitBucket) plugin, a pull-request decorator which allows to integrate SonarQube violations directly into your pull-request
MIT License
165 stars 82 forks source link

Tie approval to pass of the quality gate #95

Open t-8ch opened 7 years ago

t-8ch commented 7 years ago

We should change the logic of approval of a PR to the configured quality gate instead of the number of issues.

Cc @re-schneider @acopet

kzaikin commented 7 years ago

Is mentioned quality gate a sonar.stash.task.issue.severity.threshold value or a general sonar's quality gate?

t-8ch commented 7 years ago

Currently only the threshold exists. The plan is to use a generic Quality Gate. But this is still missing features on SonarQube side. See https://jira.sonarsource.com/browse/SONAR-6763