search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

To implement small optimization for job update #14

Closed sdminonne closed 7 years ago

sdminonne commented 7 years ago

Replacing DeepEqual (even if not reflect but only semantic) with ResourceVersion comparison is the common way for controllers to handle secondary resources.

codecov-io commented 7 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   24.55%   24.55%           
=======================================
  Files           8        8           
  Lines         794      794           
=======================================
  Hits          195      195           
  Misses        585      585           
  Partials       14       14
Impacted Files Coverage Δ
pkg/controller/controller.go 17.13% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9594047...ef2bb48. Read the comment docs.