search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

Fix a bug in onDeleteWorkflow and other minor stuffz #17

Closed sdminonne closed 7 years ago

sdminonne commented 7 years ago

To fix a bug in onDeleteWorkflow callback To add a check for DeletionTimestamp (and TODO) To preserve already finished job during deletion

codecov-io commented 7 years ago

Codecov Report

Merging #17 into master will decrease coverage by 0.95%. The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #17      +/-   ##
=========================================
- Coverage   24.55%   23.6%   -0.96%     
=========================================
  Files           8       8              
  Lines         794     898     +104     
=========================================
+ Hits          195     212      +17     
- Misses        585     669      +84     
- Partials       14      17       +3
Impacted Files Coverage Δ
pkg/controller/controller.go 16.94% <8.33%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 494f703...979d0ea. Read the comment docs.