search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

cascade delete jobs when deleting a workflow #19

Closed alexei-led closed 6 years ago

alexei-led commented 7 years ago

Resolves #18

When deleting a workflow, cascade delete all it's jobs disregarding of job status.

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will decrease coverage by 1.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
- Coverage   24.49%   23.4%   -1.09%     
=========================================
  Files           8       8              
  Lines         796     833      +37     
=========================================
  Hits          195     195              
- Misses        586     623      +37     
  Partials       15      15
Impacted Files Coverage Δ
pkg/controller/controller.go 15.75% <0%> (-1.27%) :arrow_down:
pkg/controller/job_control.go 0% <0%> (ø) :arrow_up:
pkg/controller/controller_util.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f13cd1...799d12c. Read the comment docs.

sdminonne commented 7 years ago

@alexei-led Thanks! Going to find some time before the end of the day to review this but it looks pretty good.

sdminonne commented 6 years ago

@alexei-led this PR solves a real problem even if I would prefer to remove jobs during sync. The definitive solution would be to add a GC. But for the moment it's better than what we have. I'm OK to merge. @clamoriniere1A @EricMountain-1A thoughts?

clamoriniere1A commented 6 years ago

@sdminonne, it's fine for me to merge this PR. @alexei-led thanks for your contribution.