Closed alexei-led closed 6 years ago
Merging #23 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #23 +/- ##
======================================
Coverage 23.4% 23.4%
======================================
Files 8 8
Lines 833 833
======================================
Hits 195 195
Misses 623 623
Partials 15 15
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f0f1b6b...4ffc103. Read the comment docs.
@alexei-led I think this one can be merged but I'm double checking with @clamoriniere1A
@sdminonne thank you.
p.s.: maybe worth to open Gitter room for this project, to simplify IM communication?
This PR includes few small changes to basic K8s deployment and Helm chart:
kube-system
namespace for CRD workflow-controller and ServiceAccountlatest
image, theimagePullPolicy
should be set toAlways
workflow-controller
does not support running more than 1 replica, due to design (all replicas will get K8s events and will try to create jobs).RBAC
requires defining an additional CRB to access K8s dashboard. I've addedgke-kube-dashboard-rbac.yml
for thisp.s.: workflow-controller works nicely on a multi-node K8s GKE cluster with hundreds of running "stress" steps.