AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

Docker multistage build #24

Open alexei-led opened 6 years ago

alexei-led commented 6 years ago

Hi, guys

This is just a proposal: use Docker multistage build

This will enable to:

just one command to build docker build (or make container)

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    23.4%   23.4%           
======================================
  Files           8       8           
  Lines         833     833           
======================================
  Hits          195     195           
  Misses        623     623           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0f1b6b...1af5fba. Read the comment docs.

sdminonne commented 6 years ago

Thanks for your contribution and your time on this.

Believe me @alexei-led I see the value, just docker on my laptop is too old (even on updated fedora). Mind build the multistage in a docker or wait few weeks (to me to rework this, or simply moving to next fedora beta)?

alexei-led commented 6 years ago

@sdminonne whenever you are ready