search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

To add a Garbage collection #28

Closed sdminonne closed 6 years ago

sdminonne commented 6 years ago

@clamoriniere1A @EricMountain-1A a mind validate the approach?

codecov-io commented 6 years ago

Codecov Report

Merging #28 into master will increase coverage by 2.51%. The diff coverage is 54.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage    23.4%   25.92%   +2.51%     
==========================================
  Files           8        9       +1     
  Lines         833      841       +8     
==========================================
+ Hits          195      218      +23     
+ Misses        623      605      -18     
- Partials       15       18       +3
Impacted Files Coverage Δ
pkg/controller/controller.go 16.97% <0%> (+1.21%) :arrow_up:
pkg/controller/job_control.go 0% <0%> (ø) :arrow_up:
pkg/controller/controller_util.go 0% <0%> (ø) :arrow_up:
pkg/garbagecollector/garbagecollector.go 62.16% <62.16%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d107a8c...4285ba4. Read the comment docs.

sdminonne commented 6 years ago

Folks following the LGTM from @clamoriniere1A I would merge it. Let me know if its' good for you

sdminonne commented 6 years ago

@alexei-led as you asked this implements GC