search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

API doesn't seem to match the example. #43

Closed jhart99 closed 6 years ago

jhart99 commented 6 years ago

I was having a look at the code for this to implement a python interface for workflows like the kubernetes team does for their APIs. I noticed that there is a mismatch between the diamond.yaml example and the structures in the Go code. In the diamond.yaml there is a metadata section as part of WorkflowSpec, but in the types there are only Steps, Selector and ActiveDeadlineSeconds. It doesn't matter all that much because the diamond example still works correctly, but I just wanted to be sure that I was adding all the fields that were actually in the spec.

sdminonne commented 6 years ago

Fixed by #44

sdminonne commented 6 years ago

@jhart99 thanks for reporting this! @EricMountain-1A fixed it. :)