search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

Add Job OwnerReference at creation #49

Closed clamoriniere1A closed 6 years ago

clamoriniere1A commented 6 years ago

In order to activate the cascading deletion of resources; the deletion of a Workflow should also trigger the deletion of the associated Jobs; the workflow-controller adds now an OwnerReference of the Workflow resource on all the Jobs created.

codecov-io commented 6 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.54%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   39.48%   38.93%   -0.55%     
==========================================
  Files           9        9              
  Lines         851      863      +12     
==========================================
  Hits          336      336              
- Misses        489      501      +12     
  Partials       26       26
Impacted Files Coverage Δ
pkg/controller/controller_util.go 40.29% <0%> (-7.92%) :arrow_down:
pkg/controller/job_control.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd5280a...2521dad. Read the comment docs.