sdminonne commented 6 years ago

@clamoriniere1A @EricMountain-1A to modify code generation for informers/listers/client and deep-copy. This change is needed to:

avoiding UpdateStatus code generation for client
preparing for CronWorkflow: in my pipe (pretty advanced actually)
adding hack/update-codegen.sh and more important hack/verify-codegen.sh The latter should be added later on in the travis to check codegen is not broken.

codecov-io commented 6 years ago

Codecov Report

Merging #51 into master will increase coverage by 1.4%. The diff coverage is 0%.

@@            Coverage Diff            @@
##           master      #51     +/-   ##
=========================================
+ Coverage   38.93%   40.33%   +1.4%     
=========================================
  Files           9        9             
  Lines         863      833     -30     
=========================================
  Hits          336      336             
+ Misses        501      471     -30     
  Partials       26       26

Impacted Files	Coverage Δ
pkg/api/workflow/v1/deepcopy_generated.go	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e64f092...4a628c8. Read the comment docs.

sdminonne commented 6 years ago

cov up (since code is removed) :)

EricMountain-1A commented 6 years ago

LGTM

AmadeusITGroup / workflow-controller

New code geneneration #51

Codecov Report